Added Empty Tests for Examples #5076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5076 +/- ##
========================================
Coverage 95.53% 95.54%
========================================
Files 317 313 -4
Lines 18349 18210 -139
========================================
- Hits 17530 17398 -132
+ Misses 658 652 -6
+ Partials 161 160 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I was wrong about code coverage, examples are not excluded. Please add hotrod to ignore in |
|
and yes, add goleak to the test files |
|
should i remove this also? func TestDummy(t *testing.T) {
// This is a dummy test in the root package.
// Without it `go test -v .` prints "testing: warning: no tests to run".
} |
|
yes you can remove dummy test |
Signed-off-by: Pushkar Mishra <[email protected]>
Signed-off-by: Pushkar Mishra <[email protected]>
Signed-off-by: Pushkar Mishra <[email protected]>
yurishkuro
added
the
changelog:test
|
seems everything is good to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yurishkuro, do we also need goleak tests in examples?
Which problem is this PR solving?
Description of the changes
./examplesto reduce noise inmake nocover.How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test